Skip to content

prevAll: Document issues with reverse doc order #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

mgol
Copy link
Member

@mgol mgol commented Dec 19, 2022

.prevAll() returns elements in the reverse document order. This can pose issues when used with APIs like .append() or .wrapAll(). Document how to deal with the issue with help from jQuery.uniqueSort().

Ref jquery/jquery#5149

Screenshots of the .prevAll() page additions from this PR:

  1. A note added at the end of the main description (just before examples): Screen Shot 2022-12-19 at 15 14 34
  2. A new example at the end of the page: Screen Shot 2022-12-19 at 15 14 56 Screen Shot 2022-12-19 at 15 15 08

@mgol mgol requested review from timmywil and gibson042 December 19, 2022 14:01
@mgol mgol force-pushed the prevAll-jQuery-uniqueSort branch 2 times, most recently from dab2d6d to 87babec Compare December 19, 2022 14:12
`.prevAll()` returns elements in the reverse document order. This
can pose issues when used with APIs like `.append()` or `.wrapAll()`.
Document how to deal with the issue with help from `jQuery.uniqueSort()`.

Ref jquery/jquery#5149
@mgol mgol force-pushed the prevAll-jQuery-uniqueSort branch from 87babec to 86511a7 Compare December 19, 2022 14:31
@mgol mgol self-assigned this Dec 19, 2022
@mgol mgol added this to the 3.0.0 milestone Dec 19, 2022
@mgol mgol merged commit 9f6bbf1 into jquery:main Dec 19, 2022
@mgol mgol deleted the prevAll-jQuery-uniqueSort branch December 19, 2022 21:20
mgol added a commit that referenced this pull request May 11, 2023
Also, use it in `.prevAll()` examples instead of the
older `jQuery.uniqueSort()`.

In addition, update jQuery used in examples to `3.7.0`
and add the category for jQuery `3.7`.

Closes gh-1216
Ref gh-1215
Ref jquery/jquery#5149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants